test: add test for dgram.setTTL #2121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
The CI failures so far seem unrelated. |
| socket.bind(common.PORT); | ||
| socket.on('listening', function() { | ||
| var result = socket.setTTL(16); | ||
| assert.equal(result, 16); |
There was a problem hiding this comment.
nit: could be assert.strictEqual(socket.setTTL(16), 16); Or if that's less readable, another const. :)
Also, isn't it better to use strictEqual for this kind of stuff?
Verify that passing a non-number will throw and that the argument is returned on success. PR-URL: nodejs#2121 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 842eb5b. Thanks! |
This was referenced Nov 28, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify that passing a non-number will throw and that the argument is
returned on success.
There currently is not a test to verify this functionality.