node: remove bad fn call and check #2157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These two lines exist because of a screw up on my part while combining MakeCallback() and MakeDomainCallback(). The reason it never broke core tests is because any paths it would have broken were rerouted to AsyncWrap::MakeCallback(). The only case that node::MakeCallback() handles anymore is setImmediate(). Fix: a1da024 "node, async-wrap: remove MakeDomainCallback"
|
Failed tests are unrelated. |
brendanashworth
added
the
c++
|
LGTM |
trevnorris
added a commit
that referenced
this pull request
Jul 27, 2015
These two lines exist because of a screw up on my part while combining MakeCallback() and MakeDomainCallback(). The reason it never broke core tests is because any paths it would have broken were rerouted to AsyncWrap::MakeCallback(). The only case that node::MakeCallback() handles anymore is setImmediate(). Fix: a1da024 "node, async-wrap: remove MakeDomainCallback" PR-URL: #2157 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Thanks. Landed in 93660c8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These two lines exist because of a screw up on my part while combining
MakeCallback() and MakeDomainCallback().
The reason it never broke core tests is because any paths it would have
broken were rerouted to AsyncWrap::MakeCallback(). The only case that
node::MakeCallback() handles anymore is setImmediate().
Fix: a1da024 "node, async-wrap: remove MakeDomainCallback"
R=@bnoordhuis?
CI: https://jenkins-iojs.nodesource.com/job/iojs+any-pr+multi/145/