Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no coverage for "v8 nodeinfo" #423

Open
kvakil opened this issue Oct 1, 2022 · 4 comments
Open

no coverage for "v8 nodeinfo" #423

kvakil opened this issue Oct 1, 2022 · 4 comments

Comments

@kvakil
Copy link
Contributor

kvakil commented Oct 1, 2022

According to the coverage report there are no tests for v8 nodeinfo. Two options:

  1. Remove it. It is a couple hundred lines of code, and how often do you get a coredump where you don't know the version of Node.js you were running?
  2. Add a test for it.
@kvakil
Copy link
Contributor Author

kvakil commented Oct 1, 2022

(Apparently I can't label issues here, but this is good first issue .)

@No9
Copy link
Member

No9 commented Oct 1, 2022

Funny enough not having the right node version is a common error even among experienced developers so I would aim for adding a test.

@No9
Copy link
Member

No9 commented Oct 1, 2022

Also I'm at collab summit today I'll confirm with @mhdawson best way to formally add you to the repo so you can edit labels etc

@mhdawson
Copy link
Member

@No9 The governance for a team/related repo is generally set by the team itself. I do see that there is governance specified in this repo but it is wa....y out of date.

It might be good to update that and at this point it would probably be ok to keep it simple, maybe something that just says existing collaborators can add new collaborators when/if appropriate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants