Skip to content
This repository has been archived by the owner on Sep 2, 2023. It is now read-only.

Backporting regression fix from master to 9.x #44

Closed
MylesBorins opened this issue Mar 6, 2018 · 3 comments
Closed

Backporting regression fix from master to 9.x #44

MylesBorins opened this issue Mar 6, 2018 · 3 comments

Comments

@MylesBorins
Copy link
Member

Hey All,

we have an open PR to backport a change to modules from master to 9.x

nodejs/node#18923

Are there objections to landing this? As it had been landed on master prior to us deciding that we wanted to discuss a code freeze, I think it makes sense to backport.

@jdalton
Copy link
Member

jdalton commented Mar 6, 2018

I don't see this as controversial.
That said, bugs in something experimental are nothing new so I don't see backporting as a must either.

@benjamingr
Copy link
Member

benjamingr commented Mar 7, 2018

Are there objections to landing this? As it had been landed on master prior to us deciding that we wanted to discuss a code freeze, I think it makes sense to backport.

In general, I think that:

  • The consensus is against a code freeze at the moment, while we agreed that the current implementation might break in incompatible ways.
  • We should default to the current status, as we're not a chartered working group - even if we wanted to object to landing something we should likely do so in the "regular" TSC approved way (in the PR)

@MylesBorins
Copy link
Member Author

Thanks for chiming in folks. I landed the backport. We can discuss further in the meeting next week

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants