Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Building with clang-16 error -Wenum-constexpr-conversion #1198

Closed
ammarfaizi2 opened this issue Aug 18, 2022 · 2 comments
Closed

Building with clang-16 error -Wenum-constexpr-conversion #1198

ammarfaizi2 opened this issue Aug 18, 2022 · 2 comments

Comments

@ammarfaizi2
Copy link
Contributor

Hi,

Building with clang-16 error -Wenum-constexpr-conversion:

napi.h:1173:7: error: integer value -1 is outside the valid range of values [0, 15] for this enumeration type [-Wenum-constexpr-conversion]
      static_cast<napi_typedarray_type>(-1);
      ^
1 error generated.
@NickNaso
Copy link
Member

Hi @ammarfaizi2,
I think that this issue is correlate with PR #1066 and issue #1066 wea re working on solve it. Thanks for reporting.

@KevinEady KevinEady mentioned this issue Sep 21, 2022
Closed
@NickNaso
Copy link
Member

NickNaso commented Nov 3, 2022

I'm closing the issue because it has been solved with PR #1209

@NickNaso NickNaso closed this as completed Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: remove TypedArray::unknown_array_type KevinEady/node-addon-api
2 participants
@NickNaso @ammarfaizi2