Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Add test coverage for PropertyDescriptors #986

Closed
JckXia opened this issue Apr 30, 2021 · 2 comments
Closed

[Tests] Add test coverage for PropertyDescriptors #986

JckXia opened this issue Apr 30, 2021 · 2 comments
Labels

Comments

@JckXia
Copy link
Member

JckXia commented Apr 30, 2021

class methods
PropertyDescriptor PropertyDescriptor(napi_property_descriptor desc)
Covered #610 template <Napi::PropertyDescriptor::GetterCallback Getter> static PropertyDescriptor Napi::PropertyDescriptor::Accessor(__name, napi_property_attributes attributes = napi_default, void * data = nullptr)
Covered #610 template<GetterCallback Getter, SetterCallback Setter> static PropertyDescriptor Accessor(__name, napi_property_attributes attributes = napi_default , void * data = nullptr)
Covered #343 static PropertyDescriptor Accessor(__ name, Getter getter , napi_property_attributes attributes = napi_defaults, void * data = nullptr)
Covered #652 PropertyDescriptor Napi::PropertyDescriptor::Function( _-name, Callable cb, napi_property_attributes attributes = napi_default, void * data = nullptr)
Covered #65 PropertyDescriptor Value(__name, napi_value value, napi_property_attributes attributes = napi_default)
Covered #65 PropertyDescriptor Value(Name name, Value value, napi_property_attributes attributes = napi_default)
@NickNaso NickNaso added the test label Apr 30, 2021
@github-actions
Copy link

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Jul 30, 2021
@NickNaso NickNaso removed the stale label Jul 30, 2021
@NickNaso
Copy link
Member

I'm closing this issue because all seems to be covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants