Skip to content
This repository has been archived by the owner on Oct 15, 2020. It is now read-only.

Commit

Permalink
test: skip null-buffer-neuter on node-chakracore
Browse files Browse the repository at this point in the history
null-buffer-neuter tests GC behavior and doesn't work on node-chakracore.

PR-URL: #52
Reviewed-By: Sandeep Agarwal <Agarwal.Sandeep@microsoft.com>
  • Loading branch information
Jianchun Xu committed Apr 6, 2016
1 parent 313cec1 commit 53c2d8e
Showing 1 changed file with 8 additions and 1 deletion.
9 changes: 8 additions & 1 deletion test/addons/null-buffer-neuter/test.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,14 @@
'use strict';
// Flags: --expose-gc

require('../../common');
const common = require('../../common');
var binding = require('./build/Release/binding');

if (common.isChakraEngine) {
console.log(`1..0 # Skipped: This test is disabled for chakra engine
because it depends on v8 GC behavior. Chakra GC may find reference-like
data on native stack and may not do the GC as expected.`);
return;
}

binding.run();

0 comments on commit 53c2d8e

Please sign in to comment.