chakrashim: remove SAL annotations

SAL annotations were used inconsistently in a few files. Remove
them all instead.

Reviewed-by: @kunalspathak

deps/chakrashim/src/jsrtcontextshim.cc

@@ -324,11 +324,11 @@ bool ContextShim::InitializeBuiltIns() {
 }
 
 static JsValueRef CALLBACK ProxyOfGlobalGetPrototypeOfCallback(
-    _In_ JsValueRef callee,
-    _In_ bool isConstructCall,
-    _In_ JsValueRef *arguments,
-    _In_ unsigned short argumentCount,
-    _In_opt_ void *callbackState) {
+    JsValueRef callee,
+    bool isConstructCall,
+    JsValueRef *arguments,
+    unsigned short argumentCount,
+    void *callbackState) {
   // Return the target (which is the global object)
   return arguments[1];
 }

deps/chakrashim/src/jsrtisolateshim.cc

@@ -139,8 +139,8 @@ bool IsolateShim::IsDisposing() {
 
 // CHAKRA-TODO: This is not called after cross context work in chakra. Fix this
 // else we will leak chakrashim object.
-void CALLBACK IsolateShim::JsContextBeforeCollectCallback(
-    _In_ JsRef contextRef, _In_opt_ void *data) {
+void CALLBACK IsolateShim::JsContextBeforeCollectCallback(JsRef contextRef,
+                                                          void *data) {
   IsolateShim * isolateShim = reinterpret_cast<IsolateShim *>(data);
   ContextShim * contextShim = isolateShim->GetContextShim(contextRef);
   delete contextShim;

deps/chakrashim/src/jsrtisolateshim.h

@@ -102,8 +102,8 @@ class IsolateShim {
   explicit IsolateShim(JsRuntimeHandle runtime);
   ~IsolateShim();
   static v8::Isolate * ToIsolate(IsolateShim * isolate);
-  static void CALLBACK JsContextBeforeCollectCallback(
-    _In_ JsRef contextRef, _In_opt_ void *data);
+  static void CALLBACK JsContextBeforeCollectCallback(JsRef contextRef,
+                                                      void *data);
 
   JsRuntimeHandle runtime;
   JsPropertyIdRef symbolPropertyIdRefs[CachedSymbolPropertyIdRef::SymbolCount];

deps/chakrashim/src/jsrtproxyutils.cc

@@ -48,7 +48,7 @@ CachedPropertyIdRef GetProxyTrapCachedPropertyIdRef(ProxyTraps trap) {
 }
 
 JsErrorCode SetPropertyOnTrapConfig(
-    ProxyTraps trap, JsNativeFunction callback, _In_ JsValueRef configObj) {
+    ProxyTraps trap, JsNativeFunction callback, JsValueRef configObj) {
   if (callback == nullptr) {
     return JsNoError;
   }
@@ -70,7 +70,7 @@ JsErrorCode SetPropertyOnTrapConfig(
 
 JsErrorCode CreateProxyTrapConfig(
     const JsNativeFunction proxyConf[ProxyTraps::TrapCount],
-    _Out_ JsValueRef *confObj) {
+    JsValueRef *confObj) {
   JsErrorCode error = JsNoError;
 
   error = JsCreateObject(confObj);
@@ -93,9 +93,9 @@ JsErrorCode CreateProxyTrapConfig(
 }
 
 JsErrorCode CreateProxy(
-    _In_ JsValueRef target,
-    _In_ const JsNativeFunction config[ProxyTraps::TrapCount],
-    _Out_ JsValueRef *result) {
+    JsValueRef target,
+    const JsNativeFunction config[ProxyTraps::TrapCount],
+    JsValueRef *result) {
   JsErrorCode error;
 
   JsValueRef proxyConfigObj;

deps/chakrashim/src/jsrtproxyutils.h

@@ -49,12 +49,12 @@ enum CachedPropertyIdRef;
 CachedPropertyIdRef GetProxyTrapCachedPropertyIdRef(ProxyTraps trap);
 
 JsErrorCode CreateProxy(
-    _In_ JsValueRef target,
-    _In_ const JsNativeFunction config[ProxyTraps::TrapCount],
-    _Out_ JsValueRef *result);
+    JsValueRef target,
+    const JsNativeFunction config[ProxyTraps::TrapCount],
+    JsValueRef *result);
 
-JsErrorCode TryParseUInt32(_In_ JsValueRef strRef,
-                           _Out_ bool* isUInt32,
-                           _Out_ unsigned int *uint32Value);
+JsErrorCode TryParseUInt32(JsValueRef strRef,
+                           bool* isUInt32,
+                           unsigned int *uint32Value);
 
 }  // namespace jsrt