This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
[Converge] tests: append instead of override environment #25
Labels
Comments
|
I think that patch LGTM, although we haven't had any issues without it..
Does anyone know what platforms these are? Maybe cc @rvagg. |
|
+1 to porting this, even if it hasn't caused any problems in io.js. |
|
my only guess is I'm +1 on merging this however I'd prefer to see this generalised into a ulity in common.js |
jasnell
referenced
this issue
in jasnell/node-1
May 27, 2015
From: nodejs/node-v0.x-archive@e64ee2b Original commit message: ``` Some tests that rely on some environment variables being passed to child processes would fail because they reset the child processes' environement instead of appending to it. This would break on test environments where some custom environment variables are needed to make node work properly. ``` This port is modified to move the function into common.js per nodejs/node#25 (comment)
jasnell
referenced
this issue
in jasnell/node-1
May 27, 2015
From: nodejs/node-v0.x-archive@e64ee2b Original commit message: ``` Some tests that rely on some environment variables being passed to child processes would fail because they reset the child processes' environement instead of appending to it. This would break on test environments where some custom environment variables are needed to make node work properly. ``` This port is modified to move the function into common.js per nodejs/node#25 (comment)
jasnell
referenced
this issue
in jasnell/node-1
Jun 4, 2015
From: nodejs/node-v0.x-archive@e64ee2b Original commit message: ``` Some tests that rely on some environment variables being passed to child processes would fail because they reset the child processes' environement instead of appending to it. This would break on test environments where some custom environment variables are needed to make node work properly. ``` This port is modified to move the function into common.js per nodejs/node#25 (comment)
jasnell
referenced
this issue
in jasnell/node-1
Jun 4, 2015
From: nodejs/node-v0.x-archive@e64ee2b Original commit message: ``` Some tests that rely on some environment variables being passed to child processes would fail because they reset the child processes' environement instead of appending to it. This would break on test environments where some custom environment variables are needed to make node work properly. ``` This port is modified to move the function into common.js per nodejs/node#25 (comment)
jasnell
referenced
this issue
Jun 18, 2015
Some tests that rely on some environment variables being passed to child processes would fail because they reset the child processes' environment instead of appending to it. This would break on test environments where some custom environment variables are needed to make node work properly. PORT-FROM: joyent/node @ e64ee2b3f7b4067101b0291f1add842353cd6865 This port is modified to move the function into common.js per nodejs/node#25 (comment) PR-URL: nodejs/node#43 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
jasnell
referenced
this issue
Jun 18, 2015
Some tests that rely on some environment variables being passed to child processes would fail because they reset the child processes' environment instead of appending to it. This would break on test environments where some custom environment variables are needed to make node work properly. PORT-FROM: joyent/node @ e64ee2b3f7b4067101b0291f1add842353cd6865 This port is modified to move the function into common.js per nodejs/node#25 (comment) PR-URL: nodejs/node#43 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Landed as per nodejs/node#43 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
See: nodejs/node-v0.x-archive@e64ee2b
/cc @misterdjules @cjihrig @trevnorris
Original commit message: "Some tests that rely on some environment variables being passed to child processes would fail because they reset the child processes' environement instead of appending to it. This would break on test environments where some custom environment variables are needed to make node work properly."
The text was updated successfully, but these errors were encountered: