Skip to content
This repository has been archived by the owner on Oct 7, 2020. It is now read-only.

[converge] converged release may not include Array#values() #52

Closed
Fishrock123 opened this issue Jun 10, 2015 · 5 comments
Closed

[converge] converged release may not include Array#values() #52

Fishrock123 opened this issue Jun 10, 2015 · 5 comments

Comments

@Fishrock123
Copy link
Member

nodejs/node#1897

Re-applying it here just seems like bad practice. I really think we should wait until it lands in v8.

cc @misterdjules + @jasnell

@Fishrock123 Fishrock123 changed the title Reminder: converged release may not include Array#values() [converge] converged release may not include Array#values() Jun 10, 2015
@cjihrig
Copy link
Contributor

cjihrig commented Jun 10, 2015

+1. It only re-landed in 0.12 because it was a breaking change.

@jasnell
Copy link
Member

jasnell commented Jun 10, 2015

+1. Wasn't particularly thrilled with it landing back in v0.12. Let's add it to the list of changes to document and leave it out.

@bnoordhuis
Copy link
Member

V8 issue: https://code.google.com/p/v8/issues/detail?id=4247 - looks like V8 will ship it when Chakra does.

@misterdjules
Copy link

@bnoordhuis Thank you very much for the heads up! 👍

@Fishrock123
Copy link
Member Author

Cool, we just need to make sure we note this in the breaking changes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants