Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows: node-gyp sets wrong include path #15

Closed
piscisaureus opened this issue Feb 9, 2012 · 3 comments
Closed

Windows: node-gyp sets wrong include path #15

piscisaureus opened this issue Feb 9, 2012 · 3 comments
Labels
Windows

Comments

@piscisaureus
Copy link
Contributor

My addon is on drive d:\ and my home dir is on drive c:.

This makes node-gyp set the include path as follows:

/I"..\..\..\..\..\C:Users\Bert Belder\.node-gyp\0.7\src" /I"..\..\..\..\..\C:Users\Bert Belder\.node-gyp\0.7\deps\uv\include" /I"..\..\..\..\..\C:Users\Bert Belder\.node-gyp\0.7\deps\v8\include"
@piscisaureus
Copy link
Contributor Author

You should use path.resolve instead of path.join btw. But that alone does not fix the issue.

@TooTallNate
Copy link
Contributor

Thanks for the report Bert. These are exactly the kind of kinks I wanna iron out. However, I don't know if there's anything I can do about it. It seems to be a bug in either gyp, gyp_addon, or the addon.gypi file.

I tried running gyp_addon and msbuild manually, not using node-gyp at all and the same thing happens :(

Thanks for the tip on path.resolve() though, I'll be sure to switch those over. Where do we go from here though?

@TooTallNate TooTallNate mentioned this issue Mar 5, 2012
Closed
bnoordhuis pushed a commit to nodejs/node-v0.x-archive that referenced this issue Mar 5, 2012
@TooTallNate @bnoordhuis
addon: use absolute paths for the node include dirs
39ce942 
This fixes running gyp_addon from across filesystems on Windows.

This is essentially a gyp bug where it's not relativizing properly
across filesystems. See nodejs/node-gyp#15 for the gory details.
@TooTallNate
Copy link
Contributor

Should be fixed in node-gyp v0.2.2. Closing.

@devghost devghost mentioned this issue May 13, 2021
Closed
targos added a commit to targos/node-gyp that referenced this issue Aug 22, 2021
@targos
chore: add .gitignore (nodejs#15)
758a277 
Copied from https://github.com/github/gitignore/blob/master/Python.gitignore
@niko2 niko2 mentioned this issue Mar 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TooTallNate @piscisaureus