Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some tests fail because certificate expired #2645

Closed
targos opened this issue Apr 14, 2022 · 5 comments · Fixed by #2662
Closed

Some tests fail because certificate expired #2645

targos opened this issue Apr 14, 2022 · 5 comments · Fixed by #2662

Comments

@targos
Copy link
Member

targos commented Apr 14, 2022

See https://github.com/nodejs/gyp-next/runs/6006035910?check_suite_focus=true

    # Subtest: download over https with custom ca
        1..3
        ok 1 - should be equal
        not ok 2 - request to https://localhost:49373/ failed, reason: certificate has expired
          ---
          stack: |
            ClientRequest.<anonymous> (node_modules/minipass-fetch/lib/index.js:130:14)
          at:
            line: 130
            column: 14
            file: node_modules/minipass-fetch/lib/index.js
            function: ClientRequest.<anonymous>
          type: system
          code: CERT_HAS_EXPIRED
          errno: CERT_HAS_EXPIRED
          tapCaught: returnedPromiseRejection
          test: download over https with custom ca
          source: |
            reject(new FetchError(`request to ${request.url} failed, reason: ${
          ...
@cclauss
Copy link
Contributor

cclauss commented Apr 14, 2022

Would github-token: ${{ secrets.GITHUB_TOKEN }} work or do we need something different?

@richardlau
Copy link
Member

Would github-token: ${{ secrets.GITHUB_TOKEN }} work or do we need something different?

Something different. One (or more) of the *.crt files in https://github.com/nodejs/node-gyp/tree/master/test/fixtures used in the tests has expired.

@gengjiawen
Copy link
Member

Looks like ca.crt expired.

gitpod /workspace/node-gyp/test/fixtures (master) $ cat ca.crt | openssl x509 -noout -enddate
notAfter=Apr 11 06:22:33 2022 GMT

@gengjiawen
Copy link
Member

gengjiawen commented May 7, 2022

Looks like ca.crt expired.

gitpod /workspace/node-gyp/test/fixtures (master) $ cat ca.crt | openssl x509 -noout -enddate
notAfter=Apr 11 06:22:33 2022 GMT

@bnoordhuis Any idea how to regenerate this CA. I am not familiar with openssl.

#837

@rvagg
Copy link
Member

rvagg commented May 7, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants