util: mark util.pump() as deprecated

nodejs · Aug 5, 2012 · 3219616 · 3219616
1 parent 74d076c
commit 3219616
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/doc/api/util.markdown b/doc/api/util.markdown
@@ -170,7 +170,7 @@ Returns `true` if the given "object" is an `Error`. `false` otherwise.
 
 ## util.pump(readableStream, writableStream, [callback])
 
-Experimental
+**Deprecated**
 
 Read the data from `readableStream` and send it to the `writableStream`.
 When `writableStream.write(data)` returns `false` `readableStream` will be

diff --git a/lib/util.js b/lib/util.js
@@ -482,7 +482,7 @@ exports.exec = exports.deprecate(function() {
 }, 'util.exec is now called `child_process.exec`.');
 
 
-exports.pump = function(readStream, writeStream, callback) {
+function pump(readStream, writeStream, callback) {
   var callbackCalled = false;
 
   function call(a, b, c) {
@@ -517,7 +517,9 @@ exports.pump = function(readStream, writeStream, callback) {
     readStream.destroy();
     call(err);
   });
-};
+}
+exports.pump = exports.deprecate(pump,
+    'util.pump() is deprecated. Use ReadableStream.prototype.pump() instead.');
 
 
 /**