Closes GH-310 Format slashes properly

nodejs · Apr 2, 2011 · 4d64f36 · 4d64f36
1 parent a7254f3
commit 4d64f36
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/lib/util.js b/lib/util.js
@@ -118,9 +118,9 @@ exports.inspect = function(obj, showHidden, depth, colors) {
         return stylize('undefined', 'undefined');
 
       case 'string':
-        var simple = JSON.stringify(value).replace(/'/g, "\\'")
+        var simple = '\'' + JSON.stringify(value).replace(/^"|"$/g, '')
-                                          .replace(/\\"/g, '"')
+                                                 .replace(/'/g, "\\'")
-                                          .replace(/(^"|"$)/g, "'");
+                                                 .replace(/\\"/g, '"') + '\'';
         return stylize(simple, 'string');
 
       case 'number':

diff --git a/test/simple/test-console.js b/test/simple/test-console.js
@@ -31,11 +31,12 @@ global.process.stdout.write = function(string) {
 console.log('foo');
 console.log('foo', 'bar');
 console.log('%s %s', 'foo', 'bar', 'hop');
+console.log({slashes: '\\\\'})
 
 global.process.stdout.write = stdout_write;
 assert.equal('foo\n', strings.shift());
 assert.equal('foo bar\n', strings.shift());
 assert.equal('foo bar hop\n', strings.shift());
-
+assert.equal("{ slashes: '\\\\\\\\' }\n", strings.shift());
 
 assert.equal(true, process.stderr.write("hello world"));