Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Documentation on streams is incorrect #14351

Closed
mucus opened this issue Mar 31, 2015 · 1 comment
Closed

Documentation on streams is incorrect #14351

mucus opened this issue Mar 31, 2015 · 1 comment

Comments

@mucus
Copy link

mucus commented Mar 31, 2015

transform._flush is not called before the readable emits end. It's called after the writable has emitted a finish or prefinish.

@misterdjules
Copy link

From what I understand, these two statements are actually true, so the documentation seems to be consistent with node's behavior.

_flush is called on prefinish, and calls done when it's done, which in turns emits 'end'.

Do you see some behavior that is not consistent with that in some code? If so, could you please share that code with us?

Thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants