Skip to content
This repository has been archived by the owner on Apr 22, 2023. It is now read-only.

Investigate v0.10 flaky test test-tls-securepair-server #25719

Closed
orangemocha opened this issue Jul 17, 2015 · 0 comments
Closed

Investigate v0.10 flaky test test-tls-securepair-server #25719

orangemocha opened this issue Jul 17, 2015 · 0 comments

Comments

@orangemocha
Copy link
Contributor

a2f879f marked this test as flaky in v0.10 so that it doesn't block merges with Jenkins and node-accept-pull-request.

As a follow up, we should investigate why this test is failing in v0.10. Some of the tests marked as flaky in a2f879f fail intermittently, while others fail persistently. For the latter, an explicit skip for the specific platform might be more appropriate.

My guess is that a good percentage of these tests fail because of issues with the test itself, not node. It's likely that those issues were fixed in v0.12, so it might be a good idea to look for changes to the same test in git history in v0.12, or even simply trying the v0.12 version of the test with node v0.10.

/cc: @joyent/node-collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants