Skip to content
Permalink
Browse files

test: verify npm compatibility with releases

This adds a test that makes sure than running `npm` from a release does
not print warnings to the console.

PR-URL: #30082
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
targos committed Oct 23, 2019
1 parent ce49a41 commit 00dab3495da1951d1c167984ea9622a2dd41eb90
Showing with 24 additions and 0 deletions.
  1. +24 −0 test/parallel/test-release-npm.js
@@ -0,0 +1,24 @@
'use strict';

const common = require('../common');
const assert = require('assert');
const child_process = require('child_process');
const path = require('path');

const releaseReg = /^v\d+\.\d+\.\d+$/;

if (!releaseReg.test(process.version)) {
common.skip('This test is only for release builds');
}

{
// Verify that npm does not print out a warning when executed

const npmCli = path.join(__dirname, '../../deps/npm/bin/npm-cli.js');
const npmExec = child_process.spawnSync(process.execPath, [npmCli]);
assert.strictEqual(npmExec.status, 1);

const stderr = npmExec.stderr.toString();
assert.strictEqual(stderr.length, 0, 'npm is not ready for this release ' +
'and is going to print warnings to users:\n' + stderr);
}

0 comments on commit 00dab34

Please sign in to comment.
You can’t perform that action at this time.