Skip to content

Commit

Permalink
src: remove unnecessary call to SSL_get_mode
Browse files Browse the repository at this point in the history
SSL_set_mode() bit-ORs its argument into the current mode, its not
necessary for to do it ourself (though it doesn't cause harm).

See:
- https://www.openssl.org/docs/man1.1.0/ssl/SSL_set_mode.html
- https://github.com/nodejs/node/blob/0ce615c4af/deps/openssl/openssl/ssl/ssl_lib.c#L2176-L2177

PR-URL: #25711
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
  • Loading branch information
sam-github authored and addaleax committed Jan 28, 2019
1 parent 7ba6650 commit 09a1085
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions src/tls_wrap.cc
Expand Up @@ -110,8 +110,7 @@ void TLSWrap::InitSSL() {
SSL_set_verify(ssl_.get(), SSL_VERIFY_NONE, crypto::VerifyCallback); SSL_set_verify(ssl_.get(), SSL_VERIFY_NONE, crypto::VerifyCallback);


#ifdef SSL_MODE_RELEASE_BUFFERS #ifdef SSL_MODE_RELEASE_BUFFERS
long mode = SSL_get_mode(ssl_.get()); // NOLINT(runtime/int) SSL_set_mode(ssl_.get(), SSL_MODE_RELEASE_BUFFERS);
SSL_set_mode(ssl_.get(), mode | SSL_MODE_RELEASE_BUFFERS);
#endif // SSL_MODE_RELEASE_BUFFERS #endif // SSL_MODE_RELEASE_BUFFERS


SSL_set_app_data(ssl_.get(), this); SSL_set_app_data(ssl_.get(), this);
Expand Down

0 comments on commit 09a1085

Please sign in to comment.