Skip to content

Commit

Permalink
errors: remove needless lazyAssert
Browse files Browse the repository at this point in the history
PR-URL: #11891
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
  • Loading branch information
DavidCai1111 authored and MylesBorins committed Mar 28, 2017
1 parent 486bd1b commit 0f2642e
Showing 1 changed file with 2 additions and 9 deletions.
11 changes: 2 additions & 9 deletions lib/internal/errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,11 @@
// value statically and permanently identifies the error. While the error
// message may change, the code should not.

const assert = require('assert');
const kCode = Symbol('code');
const messages = new Map();

var assert, util;
function lazyAssert() {
if (!assert)
assert = require('assert');
return assert;
}

var util;
function lazyUtil() {
if (!util)
util = require('util');
Expand All @@ -41,7 +36,6 @@ function makeNodeError(Base) {
}

function message(key, args) {
const assert = lazyAssert();
assert.strictEqual(typeof key, 'string');
const util = lazyUtil();
const msg = messages.get(key);
Expand All @@ -60,7 +54,6 @@ function message(key, args) {
// Utility function for registering the error codes. Only used here. Exported
// *only* to allow for testing.
function E(sym, val) {
const assert = lazyAssert();
assert(messages.has(sym) === false, `Error symbol: ${sym} was already used.`);
messages.set(sym, typeof val === 'function' ? val : String(val));
}
Expand Down

0 comments on commit 0f2642e

Please sign in to comment.