Skip to content

Commit

Permalink
quic: resolve InitializeSecureContext TODO comment
Browse files Browse the repository at this point in the history
Using a static label is sufficient.

PR-URL: #34741
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
jasnell committed Aug 17, 2020
1 parent 2405922 commit 19e712b
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions src/quic/node_quic_crypto.cc
Original file line number Diff line number Diff line change
Expand Up @@ -602,8 +602,6 @@ void InitializeSecureContext(
BaseObjectPtr<crypto::SecureContext> sc,
bool early_data,
ngtcp2_crypto_side side) {
// TODO(@jasnell): Using a static value for this at the moment but
// we need to determine if a non-static or per-session value is better.
constexpr static unsigned char session_id_ctx[] = "node.js quic server";
switch (side) {
case NGTCP2_CRYPTO_SIDE_SERVER:
Expand Down

0 comments on commit 19e712b

Please sign in to comment.