Skip to content
Permalink
Browse files

test: change order of assert.strictEquals arguments

Fix assert.strictEquals argument order.

Arguments were actual first, expected second, contrary to
the documentation. Now, actual value is first and expected
value is second.

PR-URL: #23600
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information...
chucktheobald authored and jasnell committed Oct 12, 2018
1 parent e345897 commit 1c6a55146e0ddb03f15f9556e408055d1507ec83
Showing with 10 additions and 10 deletions.
  1. +10 −10 test/parallel/test-tcp-wrap-listen.js
@@ -10,15 +10,15 @@ const { WriteWrap } = internalBinding('stream_wrap');
const server = new TCP(TCPConstants.SOCKET);

const r = server.bind('0.0.0.0', 0);
assert.strictEqual(0, r);
assert.strictEqual(r, 0);
let port = {};
server.getsockname(port);
port = port.port;

server.listen(128);

server.onconnection = (err, client) => {
assert.strictEqual(0, client.writeQueueSize);
assert.strictEqual(client.writeQueueSize, 0);
console.log('got connection');

const maybeCloseClient = () => {
@@ -34,7 +34,7 @@ server.onconnection = (err, client) => {
if (buffer) {
assert.ok(buffer.length > 0);

assert.strictEqual(0, client.writeQueueSize);
assert.strictEqual(client.writeQueueSize, 0);

const req = new WriteWrap();
req.async = false;
@@ -44,23 +44,23 @@ server.onconnection = (err, client) => {

console.log(`client.writeQueueSize: ${client.writeQueueSize}`);
// 11 bytes should flush
assert.strictEqual(0, client.writeQueueSize);
assert.strictEqual(client.writeQueueSize, 0);

if (req.async)
req.oncomplete = common.mustCall(done);
else
process.nextTick(done.bind(null, 0, client, req));

function done(status, client_, req_) {
assert.strictEqual(req, client.pendingWrites.shift());
assert.strictEqual(client.pendingWrites.shift(), req);

// Check parameters.
assert.strictEqual(0, status);
assert.strictEqual(client, client_);
assert.strictEqual(req, req_);
assert.strictEqual(status, 0);
assert.strictEqual(client_, client);
assert.strictEqual(req_, req);

console.log(`client.writeQueueSize: ${client.writeQueueSize}`);
assert.strictEqual(0, client.writeQueueSize);
assert.strictEqual(client.writeQueueSize, 0);

maybeCloseClient();
}
@@ -82,7 +82,7 @@ c.on('connect', common.mustCall(() => { c.end('hello world'); }));

c.setEncoding('utf8');
c.on('data', common.mustCall((d) => {
assert.strictEqual('hello world', d);
assert.strictEqual(d, 'hello world');
}));

c.on('close', () => {

0 comments on commit 1c6a551

Please sign in to comment.
You can’t perform that action at this time.