Skip to content

Commit

Permalink
test: remove tests that create very large buffers
Browse files Browse the repository at this point in the history
With V8 11.9, the maximum ArrayBuffer length can be as high as 2**53,
which is a bit too large for current hardware.

PR-URL: #50115
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
  • Loading branch information
targos committed Jan 4, 2024
1 parent 1528846 commit 2341805
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 32 deletions.
24 changes: 0 additions & 24 deletions test/parallel/test-blob-buffer-too-large.js

This file was deleted.

8 changes: 0 additions & 8 deletions test/parallel/test-buffer-slow.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,6 @@ for (const [key, value] of sb.entries()) {

// Should work with edge cases
assert.strictEqual(SlowBuffer(0).length, 0);
try {
assert.strictEqual(
SlowBuffer(buffer.kMaxLength).length, buffer.kMaxLength);
} catch (e) {
// Don't match on message as it is from the JavaScript engine. V8 and
// ChakraCore provide different messages.
assert.strictEqual(e.name, 'RangeError');
}

// Should throw with invalid length type
const bufferInvalidTypeMsg = {
Expand Down

0 comments on commit 2341805

Please sign in to comment.