Skip to content

Commit

Permalink
stream: do not defer construction by one microtick
Browse files Browse the repository at this point in the history
Fixes: #51993
PR-URL: #52005
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
  • Loading branch information
mcollina authored and richardlau committed Mar 23, 2024
1 parent c70383b commit 270b519
Show file tree
Hide file tree
Showing 2 changed files with 29 additions and 5 deletions.
6 changes: 1 addition & 5 deletions lib/internal/streams/destroy.js
Original file line number Diff line number Diff line change
Expand Up @@ -267,7 +267,7 @@ function constructNT(stream) {
} else if (err) {
errorOrDestroy(stream, err, true);
} else {
process.nextTick(emitConstructNT, stream);
stream.emit(kConstruct);
}
}

Expand All @@ -280,10 +280,6 @@ function constructNT(stream) {
}
}

function emitConstructNT(stream) {
stream.emit(kConstruct);
}

function isRequest(stream) {
return stream?.setHeader && typeof stream.abort === 'function';
}
Expand Down
28 changes: 28 additions & 0 deletions test/parallel/test-fs-writestream-open-write.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
'use strict';

const common = require('../common');
const tmpdir = require('../common/tmpdir');
const { strictEqual } = require('assert');
const fs = require('fs');

// Regression test for https://github.com/nodejs/node/issues/51993

tmpdir.refresh();

const file = tmpdir.resolve('test-fs-writestream-open-write.txt');

const w = fs.createWriteStream(file);

w.on('open', common.mustCall(() => {
w.write('hello');

process.nextTick(() => {
w.write('world');
w.end();
});
}));

w.on('close', common.mustCall(() => {
strictEqual(fs.readFileSync(file, 'utf8'), 'helloworld');
fs.unlinkSync(file);
}));

0 comments on commit 270b519

Please sign in to comment.