Skip to content

Commit

Permalink
test: fix assert.strictEqual argument order
Browse files Browse the repository at this point in the history
PR-URL: #23457
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information
andy-ganchrow authored and MylesBorins committed Oct 30, 2018
1 parent 58a5b76 commit 2f920ce
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions test/parallel/test-vm-new-script-new-context.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ const Script = require('vm').Script;
const script = new Script('\'passed\';');
const result1 = script.runInNewContext();
const result2 = script.runInNewContext();
assert.strictEqual('passed', result1);
assert.strictEqual('passed', result2);
assert.strictEqual(result1, 'passed');
assert.strictEqual(result2, 'passed');
}

{
Expand All @@ -52,7 +52,7 @@ const Script = require('vm').Script;
global.hello = 5;
const script = new Script('hello = 2');
script.runInNewContext();
assert.strictEqual(5, global.hello);
assert.strictEqual(global.hello, 5);

// Cleanup
delete global.hello;
Expand All @@ -68,9 +68,9 @@ const Script = require('vm').Script;
/* eslint-disable no-unused-vars */
const baz = script.runInNewContext(global.obj);
/* eslint-enable no-unused-vars */
assert.strictEqual(1, global.obj.foo);
assert.strictEqual(2, global.obj.bar);
assert.strictEqual(2, global.foo);
assert.strictEqual(global.obj.foo, 1);
assert.strictEqual(global.obj.bar, 2);
assert.strictEqual(global.foo, 2);

// cleanup
delete global.code;
Expand Down

0 comments on commit 2f920ce

Please sign in to comment.