Skip to content

Commit

Permalink
tools: update V8 gypfiles for 9.8
Browse files Browse the repository at this point in the history
PR-URL: #41610
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
targos committed Feb 2, 2022
1 parent aa7dc80 commit 30c4e1d
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 13 deletions.
11 changes: 5 additions & 6 deletions tools/v8_gypfiles/features.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -151,9 +151,6 @@
# into relaxed atomic operations.
'v8_enable_atomic_object_field_writes%': 1,

# Sets -dV8_ATOMIC_MARKING_STATE
'v8_enable_atomic_marking_state%': 1,

# Has no effect in Node.js. Here for completeness with V8's config.
'v8_enable_concurrent_marking%': 1,

Expand Down Expand Up @@ -236,6 +233,8 @@

'v8_scriptormodule_legacy_lifetime%': 1,

'v8_include_receiver_in_argc%': 1,

# Variables from v8.gni

# Enable ECMAScript Internationalization API. Enabling this feature will
Expand Down Expand Up @@ -358,9 +357,6 @@
['v8_enable_atomic_object_field_writes==1', {
'defines': ['V8_ATOMIC_OBJECT_FIELD_WRITES',],
}],
['v8_enable_atomic_marking_state==1', {
'defines': ['V8_ATOMIC_MARKING_STATE',],
}],
['v8_enable_lazy_source_positions==1', {
'defines': ['V8_ENABLE_LAZY_SOURCE_POSITIONS',],
}],
Expand Down Expand Up @@ -412,6 +408,9 @@
['v8_advanced_bigint_algorithms==1', {
'defines': ['V8_ADVANCED_BIGINT_ALGORITHMS',],
}],
['v8_include_receiver_in_argc==1', {
'defines': ['V8_INCLUDE_RECEIVER_IN_ARGC',],
}],
], # conditions
'defines': [
'V8_GYP_BUILD',
Expand Down
1 change: 1 addition & 0 deletions tools/v8_gypfiles/toolchain.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,7 @@
'defines': [
'WIN32',
'NOMINMAX', # Refs: https://chromium-review.googlesource.com/c/v8/v8/+/1456620
'_WIN32_WINNT=0x0602', # Windows 8
],
# 4351: VS 2005 and later are warning us that they've fixed a bug
# present in VS 2003 and earlier.
Expand Down
8 changes: 1 addition & 7 deletions tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -87,11 +87,11 @@
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/exported-macros-assembler.h",
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/factory.cc",
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/factory.inc",
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/field-offsets.h",
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/instance-types.h",
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/interface-descriptors.inc",
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/objects-body-descriptors-inl.inc",
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/objects-printer.cc",
"<(SHARED_INTERMEDIATE_DIR)/torque-generated/visitor-lists.h",
'<@(torque_outputs_csa_cc)',
'<@(torque_outputs_csa_h)',
'<@(torque_outputs_inl_inc)',
Expand Down Expand Up @@ -1135,11 +1135,6 @@
'<(V8_ROOT)/src/base/platform/platform-win32.cc',
'<(V8_ROOT)/src/base/win32-headers.h',
],
'conditions': [
['target_arch == "arm64"', {
'defines': ['_WIN32_WINNT=0x0602'], # For GetCurrentThreadStackLimits on Windows on Arm
}],
],
'defines': ['_CRT_RAND_S'], # for rand_s()
'direct_dependent_settings': {
'msvs_settings': {
Expand Down Expand Up @@ -1733,7 +1728,6 @@
'is_ubsan_vptr=0',
'target_cpu=<(target_arch)',
'v8_current_cpu=<(v8_current_cpu)',
'v8_enable_atomic_marking_state=<(v8_enable_atomic_marking_state)',
'v8_enable_atomic_object_field_writes=<(v8_enable_atomic_object_field_writes)',
'v8_enable_concurrent_marking=<(v8_enable_concurrent_marking)',
'v8_enable_i18n_support=<(v8_enable_i18n_support)',
Expand Down

0 comments on commit 30c4e1d

Please sign in to comment.