Skip to content
Permalink
Browse files
net: remove deprecated getters for internals
Remove the getters introduced in 75a19fb.

PR-URL: #17141
Refs: #14449
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
addaleax authored and jasnell committed Nov 22, 2017
1 parent 8f50407 commit 3701b0230961644186fbc4ea2d6ef978601ac0f6
Showing with 1 addition and 29 deletions.
  1. +1 −1 doc/api/deprecations.md
  2. +0 −28 lib/net.js
@@ -640,7 +640,7 @@ Type: End-of-Life
<a id="DEP0073"></a>
### DEP0073: Several internal properties of net.Server

Type: Runtime
Type: End-of-Life

Accessing several internal, undocumented properties of `net.Server` instances
with inappropriate names has been deprecated.
@@ -1734,34 +1734,6 @@ if (process.platform === 'win32') {
_setSimultaneousAccepts = function(handle) {};
}

// TODO(addaleax): Remove these after the Node 9.x branch cut.
Object.defineProperty(Server.prototype, '_usingSlaves', {
get: internalUtil.deprecate(function() {
return this._usingWorkers;
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
set: internalUtil.deprecate((val) => {
this._usingWorkers = val;
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
configurable: true, enumerable: false
});

Object.defineProperty(Server.prototype, '_slaves', {
get: internalUtil.deprecate(function() {
return this._workers;
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
set: internalUtil.deprecate((val) => {
this._workers = val;
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
configurable: true, enumerable: false
});

Object.defineProperty(Server.prototype, '_setupSlave', {
value: internalUtil.deprecate(function(socketList) {
return this._setupWorker(socketList);
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
configurable: true, enumerable: false
});

module.exports = {
_createServerHandle: createServerHandle,
_normalizeArgs: normalizeArgs,

0 comments on commit 3701b02

Please sign in to comment.