Skip to content

Commit 3701b02

Browse files
addaleaxjasnell
authored andcommitted
net: remove deprecated getters for internals
Remove the getters introduced in 75a19fb. PR-URL: #17141 Refs: #14449 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent 8f50407 commit 3701b02

File tree

2 files changed

+1
-29
lines changed

2 files changed

+1
-29
lines changed

doc/api/deprecations.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -640,7 +640,7 @@ Type: End-of-Life
640640
<a id="DEP0073"></a>
641641
### DEP0073: Several internal properties of net.Server
642642

643-
Type: Runtime
643+
Type: End-of-Life
644644

645645
Accessing several internal, undocumented properties of `net.Server` instances
646646
with inappropriate names has been deprecated.

lib/net.js

Lines changed: 0 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -1734,34 +1734,6 @@ if (process.platform === 'win32') {
17341734
_setSimultaneousAccepts = function(handle) {};
17351735
}
17361736

1737-
// TODO(addaleax): Remove these after the Node 9.x branch cut.
1738-
Object.defineProperty(Server.prototype, '_usingSlaves', {
1739-
get: internalUtil.deprecate(function() {
1740-
return this._usingWorkers;
1741-
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
1742-
set: internalUtil.deprecate((val) => {
1743-
this._usingWorkers = val;
1744-
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
1745-
configurable: true, enumerable: false
1746-
});
1747-
1748-
Object.defineProperty(Server.prototype, '_slaves', {
1749-
get: internalUtil.deprecate(function() {
1750-
return this._workers;
1751-
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
1752-
set: internalUtil.deprecate((val) => {
1753-
this._workers = val;
1754-
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
1755-
configurable: true, enumerable: false
1756-
});
1757-
1758-
Object.defineProperty(Server.prototype, '_setupSlave', {
1759-
value: internalUtil.deprecate(function(socketList) {
1760-
return this._setupWorker(socketList);
1761-
}, 'Accessing internal properties of net.Server is deprecated.', 'DEP0073'),
1762-
configurable: true, enumerable: false
1763-
});
1764-
17651737
module.exports = {
17661738
_createServerHandle: createServerHandle,
17671739
_normalizeArgs: normalizeArgs,

0 commit comments

Comments
 (0)