Skip to content

Commit 5008c5a

Browse files
Joseph Gordonjasnell
authored andcommitted
doc: improved flow for macOS firewall script
PR-URL: #18689 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 7248171 commit 5008c5a

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

BUILDING.md

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -124,18 +124,20 @@ On macOS, you will need to install the `Xcode Command Line Tools` by running
124124
installed, you can find them under the menu `Xcode -> Open Developer Tool ->
125125
More Developer Tools...`. This step will install `clang`, `clang++`, and
126126
`make`.
127-
* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh)
128-
to avoid popups asking to accept incoming network connections when running
129-
tests:
130127

131128
If the path to your build directory contains a space, the build will likely
132129
fail.
133130

131+
After building, setting up [firewall rules](tools/macosx-firewall.sh) can avoid
132+
popups asking to accept incoming network connections when running tests.
133+
134+
Running the following script on macOS will add the firewall rules for the
135+
executable `node` in the `out` directory and the symbolic `node` link in the
136+
project's root directory.
137+
134138
```console
135139
$ sudo ./tools/macosx-firewall.sh
136140
```
137-
Running this script will add rules for the executable `node` in the `out`
138-
directory and the symbolic `node` link in the project's root directory.
139141

140142
On FreeBSD and OpenBSD, you may also need:
141143
* libexecinfo

0 commit comments

Comments
 (0)