child_process: make process_wrap binding internal

PR-URL: #22479 Refs: #22160 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs · Aug 27, 2018 · 56cf058 · 56cf058
1 parent 68dff4a
commit 56cf058
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 4 deletions.
diff --git a/lib/internal/bootstrap/node.js b/lib/internal/bootstrap/node.js
@@ -350,6 +350,7 @@
       new SafeSet([
         'uv',
         'http_parser',
+        'process_wrap',
         'v8',
         'stream_wrap',
         'signal_wrap',

diff --git a/lib/internal/child_process.js b/lib/internal/child_process.js
@@ -23,7 +23,7 @@ const assert = require('assert');
 
 const { internalBinding } = require('internal/bootstrap/loaders');
 
-const { Process } = process.binding('process_wrap');
+const { Process } = internalBinding('process_wrap');
 const { WriteWrap } = internalBinding('stream_wrap');
 const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap');
 const { TTY } = process.binding('tty_wrap');

diff --git a/src/process_wrap.cc b/src/process_wrap.cc
@@ -315,4 +315,4 @@ class ProcessWrap : public HandleWrap {
 }  // anonymous namespace
 }  // namespace node
 
-NODE_BUILTIN_MODULE_CONTEXT_AWARE(process_wrap, node::ProcessWrap::Initialize)
+NODE_MODULE_CONTEXT_AWARE_INTERNAL(process_wrap, node::ProcessWrap::Initialize)
diff --git a/test/parallel/test-process-wrap.js b/test/parallel/test-process-wrap.js
@@ -1,3 +1,4 @@
+// Flags: --expose-internals
 // Copyright Joyent, Inc. and other Node contributors.
 //
 // Permission is hereby granted, free of charge, to any person obtaining a
@@ -22,7 +23,8 @@
 'use strict';
 require('../common');
 const assert = require('assert');
-const Process = process.binding('process_wrap').Process;
+const { internalBinding } = require('internal/test/binding');
+const Process = internalBinding('process_wrap').Process;
 const { Pipe, constants: PipeConstants } = process.binding('pipe_wrap');
 const pipe = new Pipe(PipeConstants.SOCKET);
 const p = new Process();

diff --git a/test/sequential/test-async-wrap-getasyncid.js b/test/sequential/test-async-wrap-getasyncid.js
@@ -182,7 +182,7 @@ if (common.hasCrypto) { // eslint-disable-line node-core/crypto-check
 }
 
 {
-  const Process = process.binding('process_wrap').Process;
+  const Process = internalBinding('process_wrap').Process;
   testInitialized(new Process(), 'Process');
 }