Skip to content

Commit

Permalink
test: fix flaky sequential/test-fs-watch-system-limit
Browse files Browse the repository at this point in the history
This test has at least once locally received `EMFILE` rather
than `ENOSPC`, which also seems to provide a reasonable error
message (which is what the test ultimately checks).

PR-URL: #23038
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
addaleax authored and targos committed Sep 24, 2018
1 parent b48dc0b commit 5d4bec3
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion test/sequential/test-fs-watch-system-limit.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ gatherStderr.on('data', common.mustCallAtLeast((chunk) => {
if (accumulated.includes('Error:') && !finished) {
assert(
accumulated.includes('ENOSPC: System limit for number ' +
'of file watchers reached'),
'of file watchers reached') ||
accumulated.includes('EMFILE: '),
accumulated);
console.log(`done after ${processes.length} processes, cleaning up`);
finished = true;
Expand Down

0 comments on commit 5d4bec3

Please sign in to comment.