Skip to content

Commit

Permalink
test: remove setTimeout in test-net-connect-unref
Browse files Browse the repository at this point in the history
Removes the setTimeout since if the test were to fail it would time out
due to the tools/test.py wrapper

PR-URL: #21969
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
  • Loading branch information
conectado authored and targos committed Jul 31, 2018
1 parent 254aa83 commit 61ae592
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions test/internet/test-net-connect-unref.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,8 @@
const common = require('../common');
const net = require('net');

const TIMEOUT = 10 * 1000;

const client = net.createConnection(53, '8.8.8.8', function() {
client.unref();
});

client.on('close', common.mustNotCall());

setTimeout(common.mustNotCall(), TIMEOUT).unref();

0 comments on commit 61ae592

Please sign in to comment.