Skip to content

Commit

Permalink
doc: fix macosx-firewall suggestion BUILDING
Browse files Browse the repository at this point in the history
Adding back the changes made by commit# 791d560, that suggests running
macosx-firewall.sh script after bulid step. These changes were deleted
by commit# fc102d0, but they are still applicable.

PR-URL: #15829
Reviewed-By: Ryan Graham <r.m.graham@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
  • Loading branch information
Suraiya-Hameed authored and MylesBorins committed Oct 25, 2017
1 parent ad69a65 commit 699cfa1
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion BUILDING.md
Expand Up @@ -91,7 +91,7 @@ On macOS you will need to install the `Xcode Command Line Tools` by running
installed, you can find them under the menu `Xcode -> Open Developer Tool ->
More Developer Tools...`. This step will install `clang`, `clang++`, and
`make`.
* You may want to setup [firewall rules](tools/macosx-firewall.sh)
* After building, you may want to setup [firewall rules](tools/macosx-firewall.sh)
to avoid popups asking to accept incoming network connections when running tests:

If the path to your build directory contains a space, the build will likely fail.
Expand Down

0 comments on commit 699cfa1

Please sign in to comment.