Skip to content

Commit

Permalink
tools,doc: use V8::DisposePlatform
Browse files Browse the repository at this point in the history
V8::ShutdownPlatform has been deprecated and does the same.

PR-URL: #41610
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
  • Loading branch information
targos committed Feb 2, 2022
1 parent 30c4e1d commit 86b77f7
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion doc/api/embedding.md
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ int main(int argc, char** argv) {
int ret = RunNodeInstance(platform.get(), args, exec_args);

V8::Dispose();
V8::ShutdownPlatform();
V8::DisposePlatform();
return ret;
}
```
Expand Down
2 changes: 1 addition & 1 deletion test/cctest/node_test_fixture.h
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@ class NodeZeroIsolateTestFixture : public ::testing::Test {
while (uv_loop_alive(&current_loop)) {
uv_run(&current_loop, UV_RUN_ONCE);
}
v8::V8::ShutdownPlatform();
v8::V8::DisposePlatform();
CHECK_EQ(0, uv_loop_close(&current_loop));
}

Expand Down
2 changes: 1 addition & 1 deletion test/embedding/embedtest.cc
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ int main(int argc, char** argv) {
int ret = RunNodeInstance(platform.get(), args, exec_args);

V8::Dispose();
V8::ShutdownPlatform();
V8::DisposePlatform();
return ret;
}

Expand Down
2 changes: 1 addition & 1 deletion tools/code_cache/mkcodecache.cc
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,6 @@ int main(int argc, char* argv[]) {
}
isolate->Dispose();

v8::V8::ShutdownPlatform();
v8::V8::DisposePlatform();
return 0;
}

0 comments on commit 86b77f7

Please sign in to comment.