Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
stream: migrate _stream_readable use error codes
PR-URL: #15042 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
- Loading branch information
1 parent
de61f97
commit 88fb359
Showing
5 changed files
with
45 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 6 additions & 2 deletions
8
test/parallel/test-stream-readable-with-unimplemented-_read.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Original file line | Diff line number | Diff line change |
---|---|---|---|
@@ -1,8 +1,12 @@ | |||
'use strict'; | 'use strict'; | ||
require('../common'); | const common = require('../common'); | ||
const stream = require('stream'); | const stream = require('stream'); | ||
const assert = require('assert'); | const assert = require('assert'); | ||
|
|
||
const readable = new stream.Readable(); | const readable = new stream.Readable(); | ||
|
|
||
assert.throws(() => readable.read(), /not implemented/); | assert.throws(() => readable.read(), common.expectsError({ | ||
code: 'ERR_STREAM_READ_NOT_IMPLEMENTED', | |||
type: Error, | |||
message: '_read() is not implemented' | |||
})); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters