Skip to content
Permalink
Browse files

deps: use nghttp2's config.h on all platforms

Fix warnings about use of htonl(), etc. by including config.h for all
platforms, defining HAVE_ARPA_INET_H on non-Windows, and therefore
including <arpa/inet.h>, which defines the host to network byte order
conversion functions.

PR-URL: #27283
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
  • Loading branch information...
sam-github committed Apr 17, 2019
1 parent 72308a5 commit 90cf2d5f008b59ee0cbe881b1835eaf6a6a77fe2
Showing with 4 additions and 2 deletions.
  1. +3 −1 deps/nghttp2/lib/includes/config.h
  2. +1 −1 deps/nghttp2/nghttp2.gyp
@@ -54,7 +54,9 @@ typedef intptr_t ssize_t;
/* #undef NOTHREADS */

/* Define to 1 if you have the <arpa/inet.h> header file. */
/* #undef HAVE_ARPA_INET_H */
#ifndef _WIN32
# define HAVE_ARPA_INET_H 1
#endif

/* Define to 1 if you have the <fcntl.h> header file. */
#define HAVE_FCNTL_H 1
@@ -12,13 +12,13 @@
'defines': [
'BUILDING_NGHTTP2',
'NGHTTP2_STATICLIB',
'HAVE_CONFIG_H',
],
'conditions': [
['OS=="win"', {
'defines': [
'WIN32',
'_WINDOWS',
'HAVE_CONFIG_H',
],
'msvs_settings': {
'VCCLCompilerTool': {

0 comments on commit 90cf2d5

Please sign in to comment.
You can’t perform that action at this time.