Skip to content

Commit

Permalink
test: remove the legacy url parser function
Browse files Browse the repository at this point in the history
PR-URL: #42656
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
  • Loading branch information
cola119 authored and juanarbol committed May 31, 2022
1 parent 0ef18fe commit 9730482
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions test/common/inspector-helper.js
Expand Up @@ -5,8 +5,7 @@ const fs = require('fs');
const http = require('http');
const fixtures = require('../common/fixtures');
const { spawn } = require('child_process');
const { parse: parseURL } = require('url');
const { pathToFileURL } = require('url');
const { URL, pathToFileURL } = require('url');
const { EventEmitter } = require('events');

const _MAINSCRIPT = fixtures.path('loop.js');
Expand Down Expand Up @@ -417,7 +416,8 @@ class NodeInstance extends EventEmitter {
const port = await this.portPromise;
return http.get({
port,
path: parseURL(devtoolsUrl).path,
family: 4,
path: new URL(devtoolsUrl).pathname,
headers: {
'Connection': 'Upgrade',
'Upgrade': 'websocket',
Expand Down

0 comments on commit 9730482

Please sign in to comment.