Skip to content

Commit

Permalink
test: rename and document tls test
Browse files Browse the repository at this point in the history
Add a short description and one question to a TLS test.
Also, rename it since the previous name might unintentionally
evoke connotations to an internet meme that would generally
not be considered appropriate in our context.

PR-URL: #20820
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
  • Loading branch information
addaleax authored and MylesBorins committed May 23, 2018
1 parent fe7e8d6 commit 9c560ca
Showing 1 changed file with 5 additions and 0 deletions.
Expand Up @@ -4,6 +4,9 @@ const common = require('../common');
if (!common.hasCrypto)
common.skip('missing crypto');

// Verify that multiple CA certificates can be provided, and that for
// convenience that can also be in newline-separated strings.

const tls = require('tls');
const fixtures = require('../common/fixtures');

Expand All @@ -30,6 +33,8 @@ function test(ca, next) {
}
}

// `ca1` is not actually necessary for the certificate validation -- maybe
// the fixtures should be written in a way that requires it?
const array = [ca1, ca2];
const string = `${ca1}\n${ca2}`;
test(array, common.mustCall(() => test(string)));

0 comments on commit 9c560ca

Please sign in to comment.