Skip to content

Commit

Permalink
src: do not pass code to ScriptCompiler::CreateCodeCacheForFunction
Browse files Browse the repository at this point in the history
This is unnecessary, deprecated, and removed in V8 7.0.

PR-URL: #22596
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
  • Loading branch information
targos committed Sep 3, 2018
1 parent 82732ef commit a7c0cb8
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/node_contextify.cc
Original file line number Diff line number Diff line change
Expand Up @@ -1102,8 +1102,8 @@ void ContextifyContext::CompileFunction(
}

if (produce_cached_data) {
const std::unique_ptr<ScriptCompiler::CachedData>
cached_data(ScriptCompiler::CreateCodeCacheForFunction(fun, code));
const std::unique_ptr<ScriptCompiler::CachedData> cached_data(
ScriptCompiler::CreateCodeCacheForFunction(fun));
bool cached_data_produced = cached_data != nullptr;
if (cached_data_produced) {
MaybeLocal<Object> buf = Buffer::Copy(
Expand Down

0 comments on commit a7c0cb8

Please sign in to comment.