Skip to content

Commit

Permalink
errors: alter ERR_HTTP2_INVALID_PSEUDOHEADER
Browse files Browse the repository at this point in the history
changes the base instance for ERR_HTTP2_INVALID_PSEUDOHEADER
from Error to TypeError as a more accurate representation
of the error.

PR-URL: #19808
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
  • Loading branch information
davidmarkclements authored and mcollina committed Apr 9, 2018
1 parent a7c25b7 commit add1c02
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
4 changes: 1 addition & 3 deletions lib/internal/errors.js
Original file line number Diff line number Diff line change
Expand Up @@ -733,10 +733,8 @@ E('ERR_HTTP2_INVALID_INFO_STATUS',
'Invalid informational status code: %s', RangeError);
E('ERR_HTTP2_INVALID_PACKED_SETTINGS_LENGTH',
'Packed settings length must be a multiple of six', RangeError);

// This should probably be a `TypeError`.
E('ERR_HTTP2_INVALID_PSEUDOHEADER',
'"%s" is an invalid pseudoheader or is used incorrectly', Error);
'"%s" is an invalid pseudoheader or is used incorrectly', TypeError);
E('ERR_HTTP2_INVALID_SESSION', 'The session has been destroyed', Error);
E('ERR_HTTP2_INVALID_SETTING_VALUE',
'Invalid value for setting "%s": %s', TypeError, RangeError);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-info-headers.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ function onStream(stream, headers, flags) {
() => stream.additionalHeaders({ ':method': 'POST' }),
{
code: 'ERR_HTTP2_INVALID_PSEUDOHEADER',
type: Error,
type: TypeError,
message: '":method" is an invalid pseudoheader or is used incorrectly'
}
);
Expand Down
2 changes: 1 addition & 1 deletion test/parallel/test-http2-util-assert-valid-pseudoheader.js
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ function isNotError(val) {
function isError(val) {
common.expectsError({
code: 'ERR_HTTP2_INVALID_PSEUDOHEADER',
type: Error,
type: TypeError,
message: '":foo" is an invalid pseudoheader or is used incorrectly'
})(val);
}
Expand Down

0 comments on commit add1c02

Please sign in to comment.