Skip to content

Commit

Permalink
deps: cherry pick d7f813b4 from V8 upstream
Browse files Browse the repository at this point in the history
Original commit message:

    GYP: Don't pass -Wno-format-pedantic to GCC.

    This flag is not understood correctly by GCC and breaks the GCC ARM and MIPS optdebug builds.

    Patch from Brendan Kirby <brendan.kirby@imgtec.com>

    BUG=

    Review URL: https://codereview.chromium.org/1369273003

    Cr-Commit-Position: refs/heads/master@{#31013}

PR-URL: #15562
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
  • Loading branch information
akos.palfi authored and MylesBorins committed Oct 25, 2017
1 parent 85800c4 commit b259fd3
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 3 deletions.
21 changes: 19 additions & 2 deletions deps/v8/build/standalone.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -367,8 +367,25 @@
# things when their commandline changes). Nothing should ever read this
# define.
'defines': ['CR_CLANG_REVISION=<!(<(DEPTH)/tools/clang/scripts/update.sh --print-revision)'],
'cflags+': [
'-Wno-format-pedantic',
'conditions': [
['host_clang==1', {
'target_conditions': [
['_toolset=="host"', {
'cflags+': [
'-Wno-format-pedantic',
],
}],
],
}],
['clang==1', {
'target_conditions': [
['_toolset=="target"', {
'cflags+': [
'-Wno-format-pedantic',
],
}],
],
}],
],
}],
],
Expand Down
2 changes: 1 addition & 1 deletion deps/v8/include/v8-version.h
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
#define V8_MAJOR_VERSION 4
#define V8_MINOR_VERSION 5
#define V8_BUILD_NUMBER 103
#define V8_PATCH_LEVEL 50
#define V8_PATCH_LEVEL 51

// Use 1 for candidates and 0 otherwise.
// (Boolean macro values are not supported by all preprocessors.)
Expand Down

0 comments on commit b259fd3

Please sign in to comment.