Skip to content

Commit

Permalink
doc: small improvements in readline code examples
Browse files Browse the repository at this point in the history
1. Consistent template literals in `console.log()`.
2. === instead of ==.
3. const instead of var.

PR-URL: #9628
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jackson Tian <shyvo1987@gmail.com>
  • Loading branch information
vsemozhetbyt authored and addaleax committed Nov 22, 2016
1 parent 731a1fa commit d62376c
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions doc/api/readline.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const rl = readline.createInterface({

rl.question('What do you think of Node.js? ', (answer) => {
// TODO: Log the answer in a database
console.log('Thank you for your valuable feedback:', answer);
console.log(`Thank you for your valuable feedback: ${answer}`);

rl.close();
});
Expand Down Expand Up @@ -403,8 +403,8 @@ For instance: `[[substr1, substr2, ...], originalsubstring]`.

```js
function completer(line) {
var completions = '.help .error .exit .quit .q'.split(' ');
var hits = completions.filter((c) => { return c.indexOf(line) == 0 });
const completions = '.help .error .exit .quit .q'.split(' ');
const hits = completions.filter((c) => { return c.indexOf(line) === 0 });
// show all completions if none found
return [hits.length ? hits : completions, line];
}
Expand Down Expand Up @@ -512,7 +512,7 @@ const rl = readline.createInterface({
});

rl.on('line', (line) => {
console.log('Line from file:', line);
console.log(`Line from file: ${line}`);
});
```

Expand Down

0 comments on commit d62376c

Please sign in to comment.