Skip to content

Commit

Permalink
deps: cherry-pick 04a06c9 from upstream V8
Browse files Browse the repository at this point in the history
Original commit message:

    [inspector] Make test byte order independent

    Change-Id: If0fdc76170ad29b4d3dadddbb32bc87c307c04af
    Reviewed-on: https://chromium-review.googlesource.com/881883
    Reviewed-by: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>
    Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org>
    Cr-Commit-Position: refs/heads/master@{#50817}

Refs: v8/v8@04a06c9

PR-URL: #18453
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yang Guo <yangguo@chromium.org>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
  • Loading branch information
targos committed Mar 7, 2018
1 parent 3b1e5d9 commit d68ee7e
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 23 deletions.
2 changes: 1 addition & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@

# Reset this number to 0 on major V8 upgrades.
# Increment by one for each non-official patch applied to deps/v8.
'v8_embedder_string': '-node.0',
'v8_embedder_string': '-node.1',

# Enable disassembler for `--print-code` v8 options
'v8_enable_disassembler': 1,
Expand Down
40 changes: 20 additions & 20 deletions deps/v8/test/inspector/runtime/get-properties-expected.txt
Original file line number Diff line number Diff line change
Expand Up @@ -54,33 +54,33 @@ Running test: testTypedArrayWithoutLength
Running test: testArrayBuffer
[[Int8Array]]
0 own number 1
1 own number 2
2 own number 3
3 own number 4
4 own number 5
5 own number 6
6 own number 7
7 own number 8
1 own number 1
2 own number 1
3 own number 1
4 own number 1
5 own number 1
6 own number 1
7 own number 1
__proto__ own object undefined
[[Uint8Array]]
0 own number 1
1 own number 2
2 own number 3
3 own number 4
4 own number 5
5 own number 6
6 own number 7
7 own number 8
1 own number 1
2 own number 1
3 own number 1
4 own number 1
5 own number 1
6 own number 1
7 own number 1
__proto__ own object undefined
[[Int16Array]]
0 own number 513
1 own number 1027
2 own number 1541
3 own number 2055
0 own number 257
1 own number 257
2 own number 257
3 own number 257
__proto__ own object undefined
[[Int32Array]]
0 own number 67305985
1 own number 134678021
0 own number 16843009
1 own number 16843009
__proto__ own object undefined

Running test: testArrayBufferWithBrokenUintCtor
Expand Down
4 changes: 2 additions & 2 deletions deps/v8/test/inspector/runtime/get-properties.js
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ InspectorTest.runAsyncTestSuite([
},

async function testArrayBuffer() {
let objectId = await evaluateToObjectId('new Uint8Array([1, 2, 3, 4, 5, 6, 7, 8]).buffer');
let objectId = await evaluateToObjectId('new Uint8Array([1, 1, 1, 1, 1, 1, 1, 1]).buffer');
let props = await Protocol.Runtime.getProperties({ objectId, ownProperties: true });
for (let prop of props.result.result) {
if (prop.name === '__proto__')
Expand All @@ -49,7 +49,7 @@ InspectorTest.runAsyncTestSuite([
this.uint8array_old = this.Uint8Array;
this.Uint8Array = 42;
})()`);
await logExpressionProperties('new Int8Array([1, 2, 3, 4, 5, 6, 7]).buffer');
await logExpressionProperties('new Int8Array([1, 1, 1, 1, 1, 1, 1]).buffer');
await evaluateToObjectId(`(function() {
this.Uint8Array = this.uint8array_old;
delete this.uint8array_old;
Expand Down

0 comments on commit d68ee7e

Please sign in to comment.