Skip to content

Commit

Permalink
build: sync V8 warning cflags with BUILD.gn
Browse files Browse the repository at this point in the history
PR-URL: #52873
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
  • Loading branch information
targos committed May 11, 2024
1 parent eed9674 commit daeb7db
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 17 deletions.
1 change: 0 additions & 1 deletion common.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
'configuring_node%': 0,
'asan%': 0,
'ubsan%': 0,
'werror': '', # Turn off -Werror in V8 build.
'visibility%': 'hidden', # V8's visibility setting
'target_arch%': 'ia32', # set v8's target architecture
'host_arch%': 'ia32', # set v8's host architecture
Expand Down
28 changes: 18 additions & 10 deletions tools/v8_gypfiles/toolchain.gypi
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@
'v8_toolset_for_shell%': 'target',

'host_os%': '<(OS)',
'werror%': '-Werror',
# For a shared library build, results in "libv8-<(soname_version).so".
'soname_version%': '',

Expand Down Expand Up @@ -133,21 +132,33 @@
'<(V8_ROOT)',
'<(V8_ROOT)/include',
],
'cflags!': ['-Wall', '-Wextra'],
'conditions': [
['clang==1', {
'cflags': [ '-Werror', '-Wno-unknown-pragmas' ],
},{
'cflags!': [ '-Wall', '-Wextra' ],
['clang==0 and OS!="win"', {
'cflags': [
# In deps/v8/BUILD.gn: if (!is_clang && !is_win) { cflags += [...] }
'-Wno-strict-overflow',
'-Wno-return-type',
'-Wno-int-in-bool-context',
'-Wno-deprecated',
'-Wno-stringop-overflow',
'-Wno-stringop-overread',
'-Wno-restrict',
'-Wno-array-bounds',
'-Wno-nonnull',
'-Wno-dangling-pointer',
# On by default in Clang and V8 requires it at least for arm64.
'-flax-vector-conversions',
],
}],
['clang==1 or OS!="win"', {
'cflags': [ '-Wno-invalid-offsetof' ],
'cflags_cc': [
# In deps/v8/BUILD.gn: if (is_clang || !is_win) { cflags += [...] }
'-Wno-invalid-offsetof',
],
'xcode_settings': {
'WARNING_CFLAGS': ['-Wno-invalid-offsetof']
# -Wno-invalid-offsetof
'GCC_WARN_ABOUT_INVALID_OFFSETOF_MACRO': 'NO',
},
}],
['v8_target_arch=="arm"', {
Expand Down Expand Up @@ -434,9 +445,6 @@
['_toolset=="target"', {
'conditions': [
['v8_target_arch==target_arch', {
'cflags': [
'-Wno-error=array-bounds', # Workaround https://gcc.gnu.org/bugzilla/show_bug.cgi?id=56273
],
'conditions': [
['v8_target_arch=="mips64el"', {
'cflags': ['-EL'],
Expand Down
6 changes: 0 additions & 6 deletions tools/v8_gypfiles/v8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -2132,12 +2132,6 @@
]
}],
],
# -Wno-invalid-offsetof flag is not valid for C.
# The flag is initially set in `toolchain.gypi` for all targets.
'cflags!': [ '-Wno-invalid-offsetof' ],
'xcode_settings': {
'WARNING_CFLAGS!': ['-Wno-invalid-offsetof']
},
'direct_dependent_settings': {
'include_dirs': [
'<(V8_ROOT)/third_party/zlib',
Expand Down

0 comments on commit daeb7db

Please sign in to comment.