Permalink
Browse files

child_process: remove unreachable execSync() code

Code coverage showed that the execSync() variable inheritStderr
was never set to the default value of true. This is because
the default case is hit whenever normalizeExecArgs() returns an
object without an 'options' property. However, this can never
be the case because normalizeExecArgs() unconditionally creates
the options object. This commit removes the unreachable code.

PR-URL: #9209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
  • Loading branch information...
cjihrig committed Oct 20, 2016
1 parent a508000 commit dd13d71eb3ee34d84ca9059d40616bd0b44ca0ed
Showing with 1 addition and 1 deletion.
  1. +1 −1 lib/child_process.js
@@ -517,7 +517,7 @@ exports.execFileSync = execFileSync;
function execSync(command /*, options*/) {
var opts = normalizeExecArgs.apply(null, arguments);
var inheritStderr = opts.options ? !opts.options.stdio : true;
var inheritStderr = !opts.options.stdio;
var ret = spawnSync(opts.file, opts.options);
ret.cmd = command;

0 comments on commit dd13d71

Please sign in to comment.