Skip to content

Commit

Permalink
test: update postmortem metadata test
Browse files Browse the repository at this point in the history
This commit updates the following postmortem metadata constants:

- v8dbg_class_SharedFunctionInfo__code__Code
  - This is now combined with SharedFunctionInfo's function_data.
  - Renamed: v8dbg_class_SharedFunctionInfo__function_data__Object
  - V8 commit: v8/v8@51ded9d

- v8dbg_class_SharedFunctionInfo__raw_name__Object and
- v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo
  - These are now combined as name_or_scope_info.
  - Renamed: v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object
  - V8 commit: v8/v8@74a663b

- v8dbg_class_SharedFunctionInfo__compiler_hints__int
  - Renamed: v8dbg_class_SharedFunctionInfo__flags__int
  - V8 commit: v8/v8@071b01b#diff-f3f182b0510ba2ee39ae87e421ff110b

Fixes: nodejs/node-v8#44
Fixes: nodejs/node-v8#48

PR-URL: #19989
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
  • Loading branch information
cjihrig authored and MylesBorins committed Jun 1, 2018
1 parent aa08f64 commit df97791
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions test/parallel/test-postmortem-metadata.js
Original file line number Diff line number Diff line change
Expand Up @@ -93,13 +93,12 @@ function getExpectedSymbols() {
'v8dbg_class_Script__source__Object',
'v8dbg_class_SeqOneByteString__chars__char',
'v8dbg_class_SeqTwoByteString__chars__char',
'v8dbg_class_SharedFunctionInfo__code__Code',
'v8dbg_class_SharedFunctionInfo__compiler_hints__int',
'v8dbg_class_SharedFunctionInfo__function_data__Object',
'v8dbg_class_SharedFunctionInfo__flags__int',
'v8dbg_class_SharedFunctionInfo__end_position__int',
'v8dbg_class_SharedFunctionInfo__function_identifier__Object',
'v8dbg_class_SharedFunctionInfo__internal_formal_parameter_count__int',
'v8dbg_class_SharedFunctionInfo__raw_name__Object',
'v8dbg_class_SharedFunctionInfo__scope_info__ScopeInfo',
'v8dbg_class_SharedFunctionInfo__name_or_scope_info__Object',
'v8dbg_class_SharedFunctionInfo__script__Object',
'v8dbg_class_SharedFunctionInfo__start_position_and_type__int',
'v8dbg_class_SlicedString__offset__SMI',
Expand Down

0 comments on commit df97791

Please sign in to comment.