Skip to content

Commit

Permalink
tools: fix d8 macOS build
Browse files Browse the repository at this point in the history
libv8_base doesn't exist anymore.

PR-URL: #37211
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
  • Loading branch information
targos authored and danielleadams committed Feb 16, 2021
1 parent 20c65b0 commit eb0daae
Showing 1 changed file with 0 additions and 11 deletions.
11 changes: 0 additions & 11 deletions tools/v8_gypfiles/d8.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -51,17 +51,6 @@
[ 'OS=="win"', {
'sources': [ '<(V8_ROOT)/src/d8/d8-windows.cc', ]
}],
[ 'component!="shared_library"', {
'conditions': [
[ 'v8_postmortem_support==1', {
'xcode_settings': {
'OTHER_LDFLAGS': [
'-Wl,-force_load,<(PRODUCT_DIR)/libv8_base.a'
],
},
}],
],
}],
['v8_enable_i18n_support==1', {
'dependencies': [
'<(icu_gyp_path):icui18n',
Expand Down

0 comments on commit eb0daae

Please sign in to comment.