Skip to content
Permalink
Browse files

test: relax expectations in test-icu-transcode

Chromium's ICU considers "latin1" and "ascii" to mean Windows-1252,
which is consistent with
[WHATWG spec](https://encoding.spec.whatwg.org/#names-and-labels). If
linked against Chromium's ICU, Node.js therefore fails
`test/parallel/test-icu-transcode`.

PR-URL: #25866
Refs: #25851
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
  • Loading branch information...
hashseed authored and addaleax committed Feb 1, 2019
1 parent 2e80b91 commit ee3165d6e7bae1a20973928d0b004c6ba60115ec
Showing with 4 additions and 4 deletions.
  1. +4 −4 test/parallel/test-icu-transcode.js
@@ -7,15 +7,15 @@ if (!common.hasIntl)

const buffer = require('buffer');
const assert = require('assert');
const orig = Buffer.from('tést €', 'utf8');
const orig = Buffer.from('těst ☕', 'utf8');

// Test Transcoding
const tests = {
'latin1': [0x74, 0xe9, 0x73, 0x74, 0x20, 0x3f],
'latin1': [0x74, 0x3f, 0x73, 0x74, 0x20, 0x3f],
'ascii': [0x74, 0x3f, 0x73, 0x74, 0x20, 0x3f],
'ucs2': [0x74, 0x00, 0xe9, 0x00, 0x73,
'ucs2': [0x74, 0x00, 0x1b, 0x01, 0x73,
0x00, 0x74, 0x00, 0x20, 0x00,
0xac, 0x20]
0x15, 0x26]
};

for (const test in tests) {

0 comments on commit ee3165d

Please sign in to comment.
You can’t perform that action at this time.