Please sign in to comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
src: deprecate legacy node::MakeCallback
The legacy MakeCallback functions do not provide a mechanism to propagate async context. This means that any native modules using these directly is likely breaking async debugging & tracing tools. For example it is possible that such a module will cause incorrect async stack traces to be reported (even when the module is not on the stack). The new MakeCallback allow the user to specify the async context in which the callback is to be executed. Ref: #13254 PR-URL: #18632 Reviewed-By: Colin Ihrig <email@example.com> Reviewed-By: Evan Lucas <firstname.lastname@example.org> Reviewed-By: Jan Krems <email@example.com> Reviewed-By: Andreas Madsen <firstname.lastname@example.org> Reviewed-By: Anna Henningsen <email@example.com> Reviewed-By: Gibson Fahnestock <firstname.lastname@example.org>
- Loading branch information
Showing with 31 additions and 19 deletions.