Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

the implement of Data.prototype.toLocaleString in Chinese is not very good #1401

Closed
yx1994 opened this issue Apr 12, 2015 · 5 comments
Closed

the implement of Data.prototype.toLocaleString in Chinese is not very good #1401

yx1994 opened this issue Apr 12, 2015 · 5 comments

Comments

@yx1994
Copy link

yx1994 commented Apr 12, 2015 

> (new Date).toLocaleString()
'Sun Apr 12 2015 20:59:41 GMT+0800 (中国标准时间)
@yx1994 yx1994 changed the title the implement of Data.prototype.toLocaleString in Chinese is not very well the implement of Data.prototype.toLocaleString in Chinese is not very good Apr 12, 2015
@bnoordhuis
Copy link
Member

What is the expected output? Note that by default io.js is compiled without i18n support.

@yx1994
Copy link
Author

yx1994 commented Apr 12, 2015

chrome:"2015/4/12 下午11:41:52"
nodejs:'2015-04-12 23:42:11'

@bnoordhuis
Copy link
Member

Right, that's because i18n is disabled. You can build with ./configure --with-intl=<small-icu|full-icu> to enable it.

@Fishrock123
Copy link
Member

See: #238

@yx1994
Copy link
Author

yx1994 commented Apr 13, 2015

Thanks all.

@yx1994 yx1994 closed this as completed Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@bnoordhuis @Fishrock123 @yx1994