Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http - ClientRequest emits close before error #15317

Closed
ronag opened this issue Sep 10, 2017 · 1 comment
Closed

http - ClientRequest emits close before error #15317

ronag opened this issue Sep 10, 2017 · 1 comment
Labels
http Issues or PRs related to the http subsystem.

Comments

@ronag
Copy link
Member

ronag commented Sep 10, 2017

Consider the following scenario:

new Promise((resolve, reject) => req.on('close', resolve).on('error', reject))

Where the error is ignored since the promise is already resolved through close.

See, https://github.com/nodejs/node/pull/15270/files#r137951611
@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Sep 10, 2017
@ronag ronag mentioned this issue Sep 11, 2017
Closed
@ronag ronag mentioned this issue Sep 19, 2017
Closed
@apapirovski
Copy link
Member

I think this was addressed in #15588?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@apapirovski @mscdex @ronag