Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash in V8 when working with big arrays #15432

Closed
danilaml opened this issue Sep 15, 2017 · 3 comments
Closed

Crash in V8 when working with big arrays #15432

danilaml opened this issue Sep 15, 2017 · 3 comments
Labels
v8 engine Issues and PRs related to the V8 dependency.

Comments

@danilaml
Copy link

Since upgrading from Node.js 8.2.1 I often get

#
# Fatal error in ../deps/v8/src/runtime/runtime-internal.cc, line 349
# Check failed: size <= kMaxRegularHeapObjectSize || space == LO_SPACE.
#

when working with large arrays.

From some investigation it looks like I've hit
https://bugs.chromium.org/p/v8/issues/detail?id=6716
which was recently fixed (not sure if it's in 6.1 or 6.2 branch).

I've tried with latest (8.5.0) Node.js and the issue is still there.

  • Version: 8.5.0
  • Platform: 4.4.0-83-generic #106-Ubuntu SMP Mon Jun 26 17:54:43 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
  • Subsystem: V8?

Code examples are in the V8 issue linked above and here.

@addaleax addaleax added the v8 engine Issues and PRs related to the V8 dependency. label Sep 15, 2017
@addaleax
Copy link
Member

From the issue it sounds like the fix made it into V8 6.1. So, if #15393 lands, we don’t have to worry about this, if not, we’d probably need to float a patch?

/cc @nodejs/v8

@psmarshall
Copy link
Contributor

V8 6.1 has landed and the fix is included there so this is fixed. @fhinkel Can you close please :D

@targos
Copy link
Member

targos commented Oct 7, 2017

I'm closing. Thanks!

@targos targos closed this as completed Oct 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

No branches or pull requests

4 participants